[Kde-pim] Re: Review Request: Handle context menu invocation using keyboard in message list

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101835/#review4336
-----------------------------------------------------------


Couldn't this use contextMenuEvent() instead? Would avoid hardcoding the key. If there are reasons against using that (like interference with the other context menu code already in there), this looks good to me.

- Volker


On July 2, 2011, 5:33 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101835/
> -----------------------------------------------------------
> 
> (Updated July 2, 2011, 5:33 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Now if the Menu key is pressed in the message list, no context menu appears.
> This patchs implements View::keyReleaseEvent to show the context menu if the user presses the Menu key.
> 
> 
> Diffs
> -----
> 
>   messagelist/core/view.h 4bae802 
>   messagelist/core/view.cpp 1163dc4 
> 
> Diff: http://git.reviewboard.kde.org/r/101835/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/