[Kde-pim] Re: Review Request: Contact Feeder port to Nepomuk DMS

[Martin Klapetek]

> On July 28, 2011, 12:22 p.m., Sebastian Trueg wrote:
> > Apart from that little email issue this looks good to me. But your code makes me wonder about the changes in the rcgen which make the generated classes sub-classes to SimpleResource. Is it really more convenient?

IMHO it improves code readability and it simplifies it a bit, ie:

        Nepomuk::SimpleResource emailRes;
        Nepomuk::NCO::EmailAddress email(&emailRes);
        graph << emailRes;

should this become just 
        Nepomuk::NCO::EmailAddress email;
        graph << email;

Makes more sense. I often caught myself thinking what should I actually put into the grpah. The second approach is better.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102084/#review5175
-----------------------------------------------------------


On July 28, 2011, 11:57 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102084/
> -----------------------------------------------------------
> 
> (Updated July 28, 2011, 11:57 a.m.)
> 
> 
> Review request for KDEPIM, Nepomuk and Christian Mollekopf.
> 
> 
> Summary
> -------
> 
> This is the port of Akonadi's Nepomuk-Contact-Feeder to the new Nepomuk SimpleResource API. It follows Christian Mollekopf's NepomukFeederAgent port.
> 
> 
> Diffs
> -----
> 
>   agents/CMakeLists.txt f742e86 
>   agents/nepomuk_contact_feeder/nepomukcontactfeeder.h 1e86efb 
>   agents/nepomuk_contact_feeder/nepomukcontactfeeder.cpp bf32ed2 
>   agents/nepomukfeeder/nepomukfeederagentbase.cpp 7133c75 
> 
> Diff: http://git.reviewboard.kde.org/r/102084/diff
> 
> 
> Testing
> -------
> 
> Created/updated a contact in KAddressBook, looked it up in Nepomuk database, all data were present.
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/