[Kde-pim] Re: Review Request: Make ETM fetch empty collections at least once

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101844/#review4381
-----------------------------------------------------------


This review has been submitted with commit 09d52e45006d36f82e5dda7bc7dc2f7e0e7a4f3c by Kevin Krammer to branch master.

- Commit


On July 3, 2011, 8:04 p.m., Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101844/
> -----------------------------------------------------------
> 
> (Updated July 3, 2011, 8:04 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> When collections are empty because they have just been created (synchronizeCollectionTree or equivalent operation), an application using EntityTreeModel will not fetch their contents, assuming they are truly empty (contain no items).
> This seems to be done for optimization purposes.
> 
> This patch make ETM only skip collections which are known to be empty.
> 
> 
> This addresses bug 271913.
>     http://bugs.kde.org/show_bug.cgi?id=271913
> 
> 
> Diffs
> -----
> 
>   akonadi/entitytreemodel_p.h 6f7f499 
>   akonadi/entitytreemodel_p.cpp d3ab393 
> 
> Diff: http://git.reviewboard.kde.org/r/101844/diff
> 
> 
> Testing
> -------
> 
> None, yet. Actually not even build (a recent compiler upgrade seems to have broken my qt-copy and now kdepimlibs won't build anymore).
> Just as a general idea for discussion
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/