[Kde-pim] Re: Review Request: Prevent the editing of an attachment when it is an encsulated message

[George Metaxas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100288/
-----------------------------------------------------------

(Updated 2011-01-04 14:21:49.193411)


Review request for KDEPIM.


Changes
-------

Added the AttachmentPart::isMessageOrMessageCollection() method to signify if an attachment is a message or message digest. Fixed the coding style in some parts and shortened the code in AttachmentControllerBase::setSelectedParts() method.


Summary
-------

When the user attempts to forward a message that contains an encapsulated message, they are shown the attachment and can edit it, by double clicking on it. However, in this case, it doesn't make sense to edit the attachment. If the user is allowed to edit the attachment, they get an error in a message box. This patch detects if the user has double clicked on an encapsulated message and proceeds to open the attachment for viewing only.


This addresses bug 232782.
    http://bugs.kde.org/show_bug.cgi?id=232782


Diffs (updated)
-----

  kmail/attachmentcontroller.h a634ce9 
  kmail/attachmentcontroller.cpp 11157d0 
  messagecomposer/attachmentcontrollerbase.cpp 1361426 
  messagecore/attachmentpart.h dd8915a 
  messagecore/attachmentpart.cpp fa006d6 

Diff: http://git.reviewboard.kde.org/r/100288/diff


Testing
-------


Thanks,

George

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/