[Kde-pim] Re: Review Request: Fix for Bug 207779 - Kmail removes empty lines in HTML

[Frank Vanderham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100281/
-----------------------------------------------------------

(Updated 2011-01-03 02:24:52.488298)


Review request for KDEPIM.


Changes
-------

I'm sorry to put everyone through this one again, but after some good discussions on IRC, I decided to refactor this fix and take out the QWebKit dependency and replace it with good ol' regular expression magic. I am doing this for two reasons:
1. Make the fix backwards applicable to 4.4, which is what I use myself in real life and I really want this fixed ASAP
2. Take out the dependency on QWebKit so that WinCE doesn't have to be excluded.

Note: the diff file I uploaded looks a bit weird here, but OK in Kompare.

I've performed all the same tests, I checked KMail, MS Outlook Express and Thunderbird as email clients and they all show the proper email format.


Summary (updated)
-------

The KMail message editor uses Qt's rich text editor functionality. The HTML markup generated by this control is not compatible with email readers such as MS Outlook. This fix intercepts the HTML markup generated by the editor and fixes the markup before sending it out.
Contrary to the previous approach, I now use good ol' regular expressions instead of the QWebKit to parse and change the HTML markup, in order to remove the QWebKit dependency. This should make the fix applicable to WinCE and also backwards compatible to 4.4 (which I hope happens, since that is my purpose here).

[Personal note: I need to stress that as end-user of KDE for business purposes myself, this is a huge problem with KMail today: my customers complain my KMail generated email looks terrible when received, which is what prompted me to roll up my sleeves and fix it myself.]


This addresses bug 207779.
    http://bugs.kde.org/show_bug.cgi?id=207779


Diffs (updated)
-----

  messagecomposer/CMakeLists.txt ae2c106 
  messagecomposer/kmeditor.cpp 86bae8a 

Diff: http://git.reviewboard.kde.org/r/100281/diff


Testing
-------

I stood up a MS system with Outlook Express and send through a number of HTML formatted emails, especially with "empty lines", bullet lists and numbered lists (which all show up mangled prior to the fix). All those emails arrived as desired.

After Torgny's comment, I also added a test case for Thunderbird: email arrived as desired. Of course, the mail viewed in KMail also looks as required.


Thanks,

Frank

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/