[Kde-pim] Re: Review Request: Include collections wich are watched in the ChangeRecorder in the EntityTreeModel

[Stephen Kelly]

Hi,

Reviewboard doesn't allow counter-proposal patches, so this is just an
email reply to the list

Christian Mollekopf wrote:
> The patch is however work in progress, but it is almost fully working in
> the cases i tested. So all I need to know is, if I'm going in the right
> direction.

You've got a lot of unrelated changes in the patch now - splitting a
move into insert/remove, emitting notifications for descendants of
monitored collections, and adding multiple monitored collection
support to ETM.

Let's split it up.

First one I'd like to deal with is splitting the move into insert and
remove. I attach patches to akonadi and kdepimlibs to make that
happen. I use the same hack as is used to report item moves, but I
don't know why the hack is there. Surely there should be a QByteArray
NotificationMessage::destResource() const ? Maybe Volker can tell us
something about that one.

As for the notifications in the case of subcollections of monitored
collections, I think that should happen in ensureDataAvailable, not in
the ETM.

All the best,

Steve.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: notifyinterresourcemove.patch
Type: text/x-diff
Size: 4213 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110127/5960ac2b/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: splitcollectionmove.patch
Type: text/x-diff
Size: 2361 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110127/5960ac2b/attachment-0001.patch>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/