[Kde-pim] Re: Review Request: Fix for Bug 207779 - Kmail removes empty lines in HTML

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100281/#review685
-----------------------------------------------------------

Ship it!


One small comment.

other then that if the tests still pass and email still look ok in non Outlook readers, ok from me.


messagecomposer/kmeditor.cpp
<http://git.reviewboard.kde.org/r/100281/#comment493>

    !paraContent.isEmpty()


- Torgny


On 2010-12-31 18:04:41, Frank Vanderham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100281/
> -----------------------------------------------------------
> 
> (Updated 2010-12-31 18:04:41)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> The KMail message editor uses Qt's rich text editor functionality. The HTML markup generated by this control is not compatible with email readers such as MS Outlook. This fix intercepts the HTML markup generated by the editor and fixes the markup before sending it out.
> The HTML parser used to fix the markup is Qt's Webkit, which, at first blush, sounds "heavy", but as discussed on IRC a couple of days ago, there is no performance loss and WebKit is already linked to Kmail, so there should be no side-effects.
> 
> [Personal note: I need to stress that as end-user of KDE for business purposes myself, this is a huge problem with KMail today: my customers complain my KMail generated email looks terrible when received, which is what prompted me to roll up my sleeves and fix it myself.]
> 
> 
> This addresses bug 207779.
>     http://bugs.kde.org/show_bug.cgi?id=207779
> 
> 
> Diffs
> -----
> 
>   messagecomposer/CMakeLists.txt 477bc29 
>   messagecomposer/kmeditor.h af9bf89 
>   messagecomposer/kmeditor.cpp 7ab1288 
> 
> Diff: http://git.reviewboard.kde.org/r/100281/diff
> 
> 
> Testing
> -------
> 
> I stood up a MS system with Outlook Express and send through a number of HTML formatted emails, especially with "empty lines", bullet lists and numbered lists (which all show up mangled prior to the fix). All those emails arrived as desired.
> 
> 
> Thanks,
> 
> Frank
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/