[Kde-pim] Review Request: Include collections wich are watched in the ChangeRecorder in the EntityTreeModel

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6330/
-----------------------------------------------------------

Review request for KDE PIM and Stephen Kelly.


Summary
-------

With this patch, the model includes also collections which are monitored in the monitor with ChangeRecorder::setCollectionMonitored() the same way it includes also watched resources.

Since I don't fully understand the whole code I just stuck to how the resource monitoring is implemented.

I had to add the fetching of the items in EntityTreeModelPrivate::topLevelCollectionsFetched(), otherwise only the items in subcollections would have been fetched. 
Since this should also have been a problem when watching resources, I reckon this was a bug.


Diffs
-----

  /trunk/KDE/kdepimlibs/akonadi/entitytreemodel_p.cpp 1213742 

Diff: http://svn.reviewboard.kde.org/r/6330/diff


Testing
-------

I'm using it in my own app, where I populate the model with items from a Akonotes resource collection and a Kcal resource collection.
It works, and I couldn't find any sideffects.


Thanks,

Christian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/