[Kde-pim] Re: Review Request: Fix for Bug 207779 - Kmail removes empty lines in HTML

[Thomas McGuire]

> On 2011-01-04 15:38:38, Thomas McGuire wrote:
> > I'll commit it to kdelibs trunk, 4.5 branch and 4.6 branch when I get around to it (probably tomorrow).
> > There is no reason not to have this in kdelibs now.
> 
> Frank Vanderham wrote:
>     Just to be sure: the diffs are for kdepim, not kdelibs.
>     
>     Also, since my business laptops and desktops are on openSUSE 11.3 + KDE4.5, which uses libkdepim4.4 / kdepim4.4, I was hoping to get this patch applied to that branch as well, so I can enjoy the fix in everyday life for me and my staff ;) Is there any chance of that?
>     
>     Or should I checkout that branch and start a new code review for that branch?

> Just to be sure: the diffs are for kdepim, not kdelibs.

I know, I can easily adapt the changes to kdelibs.

> Also, since my business laptops and desktops are on openSUSE 11.3 + KDE4.5, which uses libkdepim4.4 / kdepim4.4, I was hoping to get this patch applied to that
> branch as well, so I can enjoy the fix in everyday life for me and my staff ;) Is there any chance of that?

Hmm, how about updating kdelibs packages? If I backport to the 4.5 branch of kdelibs, that should be possible.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100281/#review728
-----------------------------------------------------------


On 2011-01-03 20:23:44, Frank Vanderham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100281/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 20:23:44)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> The KMail message editor uses Qt's rich text editor functionality. The HTML markup generated by this control is not compatible with email readers such as MS Outlook. This fix intercepts the HTML markup generated by the editor and fixes the markup before sending it out.
> Contrary to the previous approach, I now use good ol' regular expressions instead of the QWebKit to parse and change the HTML markup, in order to remove the QWebKit dependency. This should make the fix applicable to WinCE and also backwards compatible to 4.4 (which I hope happens, since that is my purpose here).
> 
> [Personal note: I need to stress that as end-user of KDE for business purposes myself, this is a huge problem with KMail today: my customers complain my KMail generated email looks terrible when received, which is what prompted me to roll up my sleeves and fix it myself.]
> 
> 
> This addresses bug 207779.
>     http://bugs.kde.org/show_bug.cgi?id=207779
> 
> 
> Diffs
> -----
> 
>   messagecomposer/CMakeLists.txt ae2c106 
>   messagecomposer/kmeditor.cpp 86bae8a 
> 
> Diff: http://git.reviewboard.kde.org/r/100281/diff
> 
> 
> Testing
> -------
> 
> I stood up a MS system with Outlook Express and send through a number of HTML formatted emails, especially with "empty lines", bullet lists and numbered lists (which all show up mangled prior to the fix). All those emails arrived as desired.
> 
> After Torgny's comment, I also added a test case for Thunderbird: email arrived as desired. Of course, the mail viewed in KMail also looks as required.
> 
> 
> Thanks,
> 
> Frank
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/