[Kde-pim] Re: Review Request: Remove blank lines in address formatting (e.g. KAddressBook display)

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5912/#review9745
-----------------------------------------------------------


- Torgny


On Nov. 20, 2010, 5:45 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5912/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2010, 5:45 p.m.)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> If a address entered into KAddressBook contains null fields or extra newlines after the address, blank lines are
> displayed in the contact details view.  This looks unattractive as well as wasting space.
> 
> The change here (to the Akonadi contact formatter) compresses multiple newlines into a single line break.
> 
> Note: If KAddressBook is built with Grantlee support then it may be necessary to make a similar change to kdepim/kaddressbook/grantleecontactformatter.cpp (function addressHash).  Have not been able to check/test this.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/akonadi/contact/standardcontactformatter.cpp 1198718 
> 
> Diff: http://svn.reviewboard.kde.org/r/5912/diff
> 
> 
> Testing
> -------
> 
> Built kdepimlibs with these changes, verified correct display with KAddressBook.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/