[Kde-pim] Re: Review Request: remove Assert on collection id change

[John Layt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100523/#review1441
-----------------------------------------------------------


This is in a file copied in from Akonadi and I would strongly prefer us not to patch them up in plasma.  I intend to occasionally update the code from Akonadi until such time as the required classes become public and we can delete the copy, so would prefer not to have keep track of additional patches to be applied.  Please try fix this in Akonadi itself and we can then copy it over intact.

- John


On Feb. 2, 2011, 8:19 a.m., Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100523/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 8:19 a.m.)
> 
> 
> Review request for KDEPIM and Plasma.
> 
> 
> Summary
> -------
> 
> Actually, there is an assert when the collection id are not the same you
> are store in your cache. I work on Zanshin and I can move an Item from a
> Collection to another and i can reproduce the same behaviour with akonadiconsole.
> 
> This path remove the assert on this case and avoid a crash when we move
> the item to a different collection.
> 
> I add kdepim in groups because a part of the code comes from kdepim/akonadi/kcal
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/calendar/akonadi/calendar.cpp 71e4fe6 
> 
> Diff: http://git.reviewboard.kde.org/r/100523/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/