[Kde-pim] Re: Review Request: Always generate a Message-ID header when composing a message

[Torgny Nyblom]

> On Feb. 20, 2011, 3:44 p.m., Ingo Klöcker wrote:
> > messagecomposer/skeletonmessagejob.cpp, line 38
> > <http://git.reviewboard.kde.org/r/100690/diff/2/?file=9604#file9604line38>
> >
> >     Minor nitpick: Move this include to the other Qt header includes (and keep the alphabetic sort order of the Qt headers).

Done


> On Feb. 20, 2011, 3:44 p.m., Ingo Klöcker wrote:
> > messagecomposer/skeletonmessagejob.cpp, line 142
> > <http://git.reviewboard.kde.org/r/100690/diff/2/?file=9604#file9604line142>
> >
> >     Using toUtf8() is no good. The Message-Id has to be ASCII-only. If localHostName is used then convert it to the 7-bit representation with QUrl::toAce(). If a custom suffix is used then ... hmm ... then remove any characters that are not allowed in a domain name. (I don't know what characters are allowed from the top of my head.)
> >     
> >     Sorry for not spotting this in my first review.

I actually thought about the localized hostnames when choosing toUtf8(), i just forgot about headers being in ASCII.


> On Feb. 20, 2011, 3:44 p.m., Ingo Klöcker wrote:
> > messagecomposer/tests/skeletonmessagejobtest.cpp, line 203
> > <http://git.reviewboard.kde.org/r/100690/diff/2/?file=9606#file9606line203>
> >
> >     composer does not seem to be destroyed. The same problem occurs in the other tests. :-( Unit tests really shouldn't leak memory knowingly because this makes it impossible to use the unit tests to uncover unknown memory leaks.
> >     
> >     I suggest creating composer on the stack:
> >     Composer composer;
> >     
> >     Fix the other tests in a separate commit.

deleted


> On Feb. 20, 2011, 3:44 p.m., Ingo Klöcker wrote:
> > messagecomposer/tests/skeletonmessagejobtest.cpp, line 208
> > <http://git.reviewboard.kde.org/r/100690/diff/2/?file=9606#file9606line208>
> >
> >     Is this also leaked? Or is it destroyed if composer is destroyed?

delete sjob; added


- Torgny


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100690/#review1528
-----------------------------------------------------------


On Feb. 20, 2011, 6:57 p.m., Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100690/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 6:57 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Always generate a Message-ID header when composing a message. This header is marked as optional according to the RFC but at the same time a comment says that it really SHOULD be present...
> 
> There is a catch... the old unit tests will fail since they do not include the Message-ID header so the tests needs to be adapted but I couldn't figure out how (at least not yet).
> 
> 
> This addresses bug 266063.
>     http://bugs.kde.org/show_bug.cgi?id=266063
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer.cpp da4c791 
>   messagecomposer/skeletonmessagejob.cpp 69b8c3e 
>   messagecomposer/tests/skeletonmessagejobtest.h d9db557 
>   messagecomposer/tests/skeletonmessagejobtest.cpp 46c0dca 
> 
> Diff: http://git.reviewboard.kde.org/r/100690/diff
> 
> 
> Testing
> -------
> 
> Mail generating and sending works.
> New unit test
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/