[Kde-pim] Re: Review Request: Always generate a Message-ID header when composing a message

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100690/
-----------------------------------------------------------

(Updated Feb. 21, 2011, 5:40 a.m.)


Review request for KDEPIM.


Changes
-------

Removed emitting error and used a fall back chain instead.
if the custom message id suffix is empty or fails to convert into an ASCII compatible encoded string fall back to QHostInfo::localHostName
if QHostInfo::localHostName fails in the same way fall back to the hard coded string "local.domain".


Summary
-------

Always generate a Message-ID header when composing a message. This header is marked as optional according to the RFC but at the same time a comment says that it really SHOULD be present...

There is a catch... the old unit tests will fail since they do not include the Message-ID header so the tests needs to be adapted but I couldn't figure out how (at least not yet).


This addresses bug 266063.
    http://bugs.kde.org/show_bug.cgi?id=266063


Diffs (updated)
-----

  messagecomposer/tests/skeletonmessagejobtest.cpp 46c0dca 
  messagecomposer/tests/skeletonmessagejobtest.h d9db557 
  messagecomposer/composer.cpp da4c791 
  messagecomposer/skeletonmessagejob.cpp 69b8c3e 

Diff: http://git.reviewboard.kde.org/r/100690/diff


Testing
-------

Mail generating and sending works.
New unit test


Thanks,

Torgny

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/