[Kde-pim] Re: Review Request: Add XLIST ability to KIMAP::ListJob

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100622/#review1332
-----------------------------------------------------------

Ship it!


Looks good.

- Kevin


On Feb. 10, 2011, 7:43 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100622/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2011, 7:43 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, Torgny Nyblom and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> Reopening this request from: http://reviewboard.kde.org/r/5928/
> See the original request for more information. It is a few month old, sorry. Only now I had the time to make the requested changes.
> 
> === Original description ===
> This patch adds the ability to list mailboxes using the XLIST command instead of LIST. XLIST is an extension to IMAP that provides localized folder names. It's prominently used by Apple's and Gmail's IMAP servers.
> 
> As the ListJob currently accepts a boolean flag to specify whether we want to include unsubscribed folders, this patch also replaces this flag by an Option enum. The includeUnsubscribed() / setIncludeUnsubscribed() are now convenience functions to set the appropriate option value, and marked as deprecated.
> 
> 
> Diffs
> -----
> 
>   kimap/listjob.h e45323b 
>   kimap/listjob.cpp 71c1d6e 
> 
> Diff: http://git.reviewboard.kde.org/r/100622/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/