[Kde-pim] Re: Review Request: Add an userName() method to KIMAP::Session

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100677/#review1481
-----------------------------------------------------------

Ship it!


Minor comment on the comments. Otherwise it's good to go IMO.


kimap/session.h
<http://git.reviewboard.kde.org/r/100677/#comment1255>

    s/setted/set/? Somehow I've a doubt about it...


- Kevin


On Feb. 18, 2011, 9:06 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100677/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2011, 9:06 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to retrieve the name of the user logged-in from a KIMAP::Session.
> This is useful since the combination of hostName + userName is a good way to identify an IMAP resource.
> 
> 
> Diffs
> -----
> 
>   kimap/session.h 0caf359 
>   kimap/session.cpp 05768ec 
>   kimap/session_p.h 50e1066 
> 
> Diff: http://git.reviewboard.kde.org/r/100677/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/