[Kde-pim] Re: Review Request: Set the source and target resource in a move notification

[Stephen Kelly]

Christian Mollekopf wrote:

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100524/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2011, 2:27 p.m.)
> 
> 
> Review request for Akonadi, KDEPIM, KDEPIM-Libraries, Volker Krause, 
and
> Stephen Kelly.
> 
> 
> Changes
> -------
> 
> forgot to add the akonadi/kdepim/kdepimlibs groups
> 
> 
> Summary
> -------
> 
> Passes the destination collection during a move in the parts array.
> Improved version of the patch from skelly (the patch now also sets 
the
> source resource correctly).

I talked to Volker about the strange hack. He said destResource was 
only omitted out of lazyness because it requires a protocol version 
bump and then a pause before updating the client libraries 
(kdepimlibs/akonadi) to use it.

Here's my counter proposal which includes explicit API for the 
destination resource for both item and collection moves.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: notifyinterresourcemove.patch
Type: text/x-patch
Size: 8430 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110204/063c7912/attachment.bin>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/