[Kde-pim] Re: Review Request: Put the value for "Use system HTTP proxy" in front the label
Torgny Nyblom
kde at nyblom.org
Fri Feb 4 06:48:43 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100536/#review1189
-----------------------------------------------------------
If you only moved the label why all the other changes?
For instance you changed the margins.
- Torgny
On Feb. 3, 2011, 5:47 p.m., Alexander Potashev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100536/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2011, 5:47 p.m.)
>
>
> Review request for KDEPIM.
>
>
> Summary
> -------
>
> Instead of QV/HBoxLayout, I used QGridLayout.
>
>
> Diffs
> -----
>
> kmail/ui/smimeconfiguration.ui 61fa252
>
> Diff: http://git.reviewboard.kde.org/r/100536/diff
>
>
> Testing
> -------
>
> The patch works for me. The screenshots are not GIMPed, they are real.
>
>
> Screenshots
> -----------
>
> before
> http://git.reviewboard.kde.org/r/100536/s/65/
> after
> http://git.reviewboard.kde.org/r/100536/s/66/
>
>
> Thanks,
>
> Alexander
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list