[Kde-pim] Re: Review Request: Always generate a Message-ID header when composing a message

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100690/#review1534
-----------------------------------------------------------


Some comments added below. I haven't had a look at the unit test issue though, sorry.


messagecomposer/skeletonmessagejob.cpp
<http://git.reviewboard.kde.org/r/100690/#comment1307>

    That error message is a bit confusing if it is ever shown to the user.
    
    There are two cases that can trigger an empty fqdn:
    1) The user has checked the checkbox to use a custom ID, but didn't actually enter one
    2) QHostInfo::localHostName() return an empty string
    
    For 1), the error should specify that exactly this happens.
    For 2), maybe just use "local.domain" as the FQDN? I think we do something similar in the SMTP slave as well.



messagecomposer/skeletonmessagejob.cpp
<http://git.reviewboard.kde.org/r/100690/#comment1306>

    Looks like messageId will be leaked here.
    If messageId is not used before the if() statement, move it after it to avoid the leak.


- Thomas


On Feb. 20, 2011, 6:57 p.m., Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100690/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2011, 6:57 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Always generate a Message-ID header when composing a message. This header is marked as optional according to the RFC but at the same time a comment says that it really SHOULD be present...
> 
> There is a catch... the old unit tests will fail since they do not include the Message-ID header so the tests needs to be adapted but I couldn't figure out how (at least not yet).
> 
> 
> This addresses bug 266063.
>     http://bugs.kde.org/show_bug.cgi?id=266063
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer.cpp da4c791 
>   messagecomposer/skeletonmessagejob.cpp 69b8c3e 
>   messagecomposer/tests/skeletonmessagejobtest.h d9db557 
>   messagecomposer/tests/skeletonmessagejobtest.cpp 46c0dca 
> 
> Diff: http://git.reviewboard.kde.org/r/100690/diff
> 
> 
> Testing
> -------
> 
> Mail generating and sending works.
> New unit test
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/