[Kde-pim] Re: Review Request: Put the value for "Use system HTTP proxy" in front the label

[Alexander Potashev]

> On Feb. 4, 2011, 9:03 a.m., Torgny Nyblom wrote:
> > If you compare the two screenshots closely you'll see that the margin between the two last rows change.
> > 
> > I don't know what difference there is in practice between using Q[VH]BoxLayout's vs. QGridLayout but I think that that change is and should be made independently to the moving of the misplaced text.
> > 
> > /Regards

This happens because the LineEdit is larger in height that a label. Btw, before the patch, the LineEdit was moved up a bit relatively to the label "Use this proxy for HTTP requests:".


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100536/#review1193
-----------------------------------------------------------


On Feb. 3, 2011, 5:47 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100536/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2011, 5:47 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Instead of QV/HBoxLayout, I used QGridLayout.
> 
> 
> Diffs
> -----
> 
>   kmail/ui/smimeconfiguration.ui 61fa252 
> 
> Diff: http://git.reviewboard.kde.org/r/100536/diff
> 
> 
> Testing
> -------
> 
> The patch works for me. The screenshots are not GIMPed, they are real.
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/100536/s/65/
> after
>   http://git.reviewboard.kde.org/r/100536/s/66/
> 
> 
> Thanks,
> 
> Alexander
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/