[Kde-pim] Review Request: windows soap groupwise fixes

[Will Stephenson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103355/#review8798
-----------------------------------------------------------


Thanks but you're gonna hate me for this: I'd prefer to just drop the groupwise resource for 4.8, since it's not ported to Akonadi and doesn't work bridged.  Sorry for letting you waste your time.

- Will Stephenson


On Dec. 7, 2011, 10:43 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103355/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2011, 10:43 p.m.)
> 
> 
> Review request for KDEPIM and Allen Winter.
> 
> 
> Description
> -------
> 
> this actually adds two fixes: one is a rather simple fix for building this code under 64bit windows.
> the other fix is needed because of a name collision on mingw of the name Unknown and because Category already has been renamed.
> 
> 
> Diffs
> -----
> 
>   kresources/groupwise/soap/patches/README 17e91cb 
>   kresources/groupwise/soap/patches/unknown_reserved.diff PRE-CREATION 
>   kresources/groupwise/soap/patches/windows-x64.diff PRE-CREATION 
>   kresources/groupwise/soap/soapStub.h d7f3d6b 
>   kresources/groupwise/soap/stdsoap2.cpp 326007d 
>   kresources/groupwise/soap/types.xsd 028a795 
> 
> Diff: http://git.reviewboard.kde.org/r/103355/diff/diff
> 
> 
> Testing
> -------
> 
> on windows.
> I haven't regenerated the soap files, but since this seems rather straightforward, I don't think anything could be harmed (except 3rdparty applications using the soap interface).
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/