[Kde-pim] Review Request: Fix 'read-only' being checked in single file resource config dialog when user didn't select it

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103310/#review8731
-----------------------------------------------------------


This review has been submitted with commit 7a57134636686a63ea8263e7944c4a619902e884 by David Jarvie to branch master.

- Commit Hook


On Dec. 4, 2011, 11:13 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103310/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2011, 11:13 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Currently, when typing the file name in the single file resource config dialog, if the entered text happens to match a read-only file which already exists, the read-only box is checked and disabled. When the user continues to type, or deletes some of the entered text, so that the name no longer matches a read-only file, the read-only box is re-enabled but is not unchecked.
> 
> This patch unchecks the read-only box when the file name no longer matches an existing read-only file, provided that the user didn't previously check it.
> 
> This prevents unintentional setting of 'read-only', and removes user confusion as to why read-only has become set when the user didn't select it.
> 
> 
> Diffs
> -----
> 
>   resources/shared/singlefileresourceconfigdialogbase.cpp ab73499 
> 
> Diff: http://git.reviewboard.kde.org/r/103310/diff/diff
> 
> 
> Testing
> -------
> 
> Tested config dialog when creating new ICal and KAlarm calendar file resources.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/