[Kde-pim] Review Request: Fix sorting of mailboxes (system folders should be on top)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103317/#review8814
-----------------------------------------------------------


This review has been submitted with commit 25bcfce5d850514783007e776a2a9363df012bad by Andras Mantia to branch master.

- Commit Hook


On Dec. 3, 2011, 7:22 p.m., Andras Mantia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103317/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2011, 7:22 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> The patch fixes the sorting of mailboxes, so Inbox/Outbox/Sent/Drafts/Trash/Templates is before the rest. This affects mostly IMAP or secondary maildir folders. The bugs is https://bugs.kde.org/show_bug.cgi?id=282189 .
> The reason I post it for review is that the changed code is probably slower (can include several dbus calls to the imap resource) than what he had before, although more correct. Local caching of folder ranks could be done on the expense of more memory usage.
> The cache could be probably cleared up when the filter proxy is invalidated.
> 
> Note for any testers: Trash is considered system folder if the IMAP account has that one selected as Trash. Drafts/Templates/Sent is considered to be a system folder if it is configured to be such for one of your identities.
> There can be only one Outbox in KMail, so IMAP Outboxes will never be considered as system folders.
> 
> Alternative solution: do the rankings based on folder names, but how to treat translated names in that case?
> 
> 
> Diffs
> -----
> 
>   mailcommon/entitycollectionorderproxymodel.cpp 09c0037 
> 
> Diff: http://git.reviewboard.kde.org/r/103317/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with an IMAP account having those folders, works fine (except for Outbox), locally with no visual slowdown, but it was not profiled.
> 
> 
> Thanks,
> 
> Andras Mantia
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/