[Kde-pim] Review Request: (minor) correct C&P error in AgentBase::collectionChanged()
Will Stephenson
wstephenson at kde.org
Mon Dec 5 11:29:18 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103334/
-----------------------------------------------------------
Review request for KDEPIM-Libraries and Volker Krause.
Description
-------
It looks like the code for the 2-argument version of collectionChanged() was copied and pasted from itemChanged and uses partIdentifiers for the second param, instead of changedAttributes. AFAIK collections have attributes and properties but not parts, and this error propagated into the nepomuk feeder, so I'm fixing it at source.
Diffs
-----
akonadi/agentbase.cpp 7e36bd6
akonadi/agentbase_p.h 34e3288
Diff: http://git.reviewboard.kde.org/r/103334/diff/diff
Testing
-------
make clean && make
Thanks,
Will Stephenson
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list