[Kde-pim] Review Request: Clear Bcc header if present before sending

[Ingo Klöcker]

[Replying to mailing list because the review was already closed.]

KMail1 has removed a lot more headers before sending. I'm not sure 
whether this is still relevant because most of those special X-KMail-* 
headers have probably been replaced with ItemAttributes. Apart from 
those special X-KMail-* headers the following two headers were removed:
  Status
  X-Status

Coding-style-wise I would have put the removal of the BCC-header into a 
separate method with a proper name.


Regards,
Ingo


On Friday 02 December 2011, Torgny Nyblom wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103308/
> -----------------------------------------------------------
> 
> Review request for KDEPIM.
> 
> 
> Description
> -------
> 
> Check if a mail has the Bcc header before sending it.
> 
> 
> This addresses bug 263587.
>     http://bugs.kde.org/show_bug.cgi?id=263587
> 
> 
> Diffs
> -----
> 
>   agents/maildispatcher/sendjob.cpp 7d465c4
> 
> Diff: http://git.reviewboard.kde.org/r/103308/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles :)
> 
> My local setup is broken so I haven't done any functional testing.
> 
> 
> Thanks,
> 
> Torgny Nyblom
> 
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20111205/3600368b/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/