[Kde-pim] Review Request: Fix loaded product ID not being set after loading a KCalCore::Calendar

David Jarvie djarvie at kde.org
Tue Aug 2 21:55:53 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102189/
-----------------------------------------------------------

Review request for KDEPIM.


Summary
-------

The loaded product ID is often not set into a KCalCore::Calendar by FileStorage::load(). It is not set at all when the saved CalFormat is used to load the calendar. It is set to the write product ID, not the loaded product ID, when VCalFormat is used to load the calendar.

This patch ensures that the loaded product ID is always set when a calendar has been loaded successfully.

This bug has prevented KAlarm from converting some old KAlarm calendars to the current format.


Diffs
-----

  kcalcore/filestorage.cpp aa0558a 

Diff: http://git.reviewboard.kde.org/r/102189/diff


Testing
-------

Tested iCalendar in KAlarm. vCalendar not tested.


Thanks,

David

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list