[Kde-pim] Review Request: akregator: bug fix 245911: crash when feed list is damaged

[Kevin Krammer]

On Thursday, 2011-08-25, Marta Rybczyńska wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102333/#review6009
> -----------------------------------------------------------
> 
> 
> Any comments?

Looks good to me but I haven't touched Akregator at any time.

Frank?

Cheers,
Kevin

> 
> - Marta
> 
> On Aug. 15, 2011, 7:49 p.m., Marta Rybczyńska wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/102333/
> > -----------------------------------------------------------
> > 
> > (Updated Aug. 15, 2011, 7:49 p.m.)
> > 
> > 
> > Review request for KDEPIM.
> > 
> > 
> > Summary
> > -------
> > 
> > Akregator segfaults when the feed list is damaged, and we try to add a
> > new feed. The reason for this is that the FeedList object to be used is
> > never correctly created, do it stays at 0. This patch provides possibly
> > the easiest solution to the problem: when the feed is damaged, we use
> > the default feed.
> > 
> > 
> > This addresses bug 245911.
> > 
> >     http://bugs.kde.org/show_bug.cgi?id=245911
> > 
> > Diffs
> > -----
> > 
> >   akregator/src/loadfeedlistcommand.cpp dda20a4
> > 
> > Diff: http://git.reviewboard.kde.org/r/102333/diff
> > 
> > 
> > Testing
> > -------
> > 
> > Tested in the situation that previously caused the bug, works fine.
> > Should not affect other cases.
> > 
> > 
> > Thanks,
> > 
> > Marta
> 
> _______________________________________________
> KDE PIM mailing list kde-pim at kde.org
> https://mail.kde.org/mailman/listinfo/kde-pim
> KDE PIM home page at http://pim.kde.org/

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20110826/f6f11627/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/