[Kde-pim] Review Request: Contact Feeder port to Nepomuk DMS

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102084/#review5651
-----------------------------------------------------------

Ship it!


If you don't get any errors except the cardinality thingy, you can ship it.


agents/nepomuk_contact_feeder/nepomukcontactfeeder.cpp
<http://git.reviewboard.kde.org/r/102084/#comment5062>

    Please comment the setIcon line for now, until we have decided how to proceed exactly.


- Christian


On July 31, 2011, 10:45 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102084/
> -----------------------------------------------------------
> 
> (Updated July 31, 2011, 10:45 a.m.)
> 
> 
> Review request for KDEPIM, Nepomuk and Christian Mollekopf.
> 
> 
> Summary
> -------
> 
> This is the port of Akonadi's Nepomuk-Contact-Feeder to the new Nepomuk SimpleResource API. It follows Christian Mollekopf's NepomukFeederAgent port.
> 
> 
> Diffs
> -----
> 
>   agents/CMakeLists.txt f742e86 
>   agents/nepomuk_contact_feeder/nepomukcontactfeeder.h 1e86efb 
>   agents/nepomuk_contact_feeder/nepomukcontactfeeder.cpp bf32ed2 
> 
> Diff: http://git.reviewboard.kde.org/r/102084/diff
> 
> 
> Testing
> -------
> 
> Created/updated a contact in KAddressBook, looked it up in Nepomuk database, all data were present.
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/