[Kde-pim] Review Request: Fixed bad performance during POP3 message download.

[Oldřich Jedlička]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102353/
-----------------------------------------------------------

(Updated Aug. 19, 2011, 5:45 p.m.)


Review request for KDEPIM.


Changes
-------

Added const to QString (I'm not sure whether this was the point of the review comment), added checking of uidString.


Summary
-------

The code uses QMap::key(value, default_value) to search for the right message ID. According to Qt documentation, the method is:
    
  This function can be slow (linear time), because QMap's internal data structure is optimized for fast lookup by key, not by value.

For lot of emails, the function is really really slow, because it tries to match every value until it finds one.


This addresses bug 277597.
    http://bugs.kde.org/show_bug.cgi?id=277597


Diffs (updated)
-----

  resources/pop3/jobs.h 53148d73b04ca400d81823ee8def87938b5b7f24 
  resources/pop3/jobs.cpp 3ce9b100132fc5a148c24dc65d639e5b8fff9c3f 
  resources/pop3/pop3resource.h 14aba203445e165dd3c8e856738d5f607ca06415 
  resources/pop3/pop3resource.cpp cc4f4203b195df1552cc2758301d54125ff3a2bd 

Diff: http://git.reviewboard.kde.org/r/102353/diff


Testing
-------


Thanks,

Oldřich

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/