[Kde-pim] Review Request: making kmail network-aware

Martin Bednar serafean at gmail.com
Thu Aug 25 13:46:56 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102431/
-----------------------------------------------------------

Review request for KDEPIM.


Summary
-------

Changes Solid calls to not render KMail useless when Solid can't detect network connection (same as Andreas did in isOffline). Asks the user to go online only based on the internal Kmail networkState status, ignoring the status of the network. Modifies behaviour of askToGoOnline() function to return false when there is no network detected, thus making checkMailOnStartup() and checkMail() functions network-aware.


Diffs
-----

  kmail/kmkernel.cpp 091209e 

Diff: http://git.reviewboard.kde.org/r/102431/diff


Testing
-------

compiles,runs, works fine with solid not detecting network, haven't bumped into any issue with Solid working.


Thanks,

Martin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list