[Kde-pim] Re: Review Request: Implement readOnly() for Akonadi kresources

[Thomas McGuire]

> On April 25, 2011, 6:55 a.m., Kevin Krammer wrote:
> > Looks good!
> > 
> > Given your test description there seems to be another bug somewhere, cause it should not ask for a save-to location if only one collection is writable.
> > But that's unrelated :)

Ok, committed.
Regrading the dialog that asks for the target folder: My description was probably confusing. It was kresources asking for the target kresource, not the Akonadi kresource asking for the target collection. That one is fixed now, since kresources used readOnly() to determine if it should ask or not. There is no other bug related to this.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101229/#review2879
-----------------------------------------------------------


On April 24, 2011, 11:57 p.m., Thomas McGuire wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101229/
> -----------------------------------------------------------
> 
> (Updated April 24, 2011, 11:57 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Summary
> -------
> 
> Right now, KOrganizer in the 4.4 branch asks me for every event I create in which resource I want to save the event, my Facebook resource or my read-write local kresource, even though the Facebook resource doesn't have write permissions.
> The reason is a missing implementation of Resource::readOnly() in the Akonadi kcal/kabc resource, which this patch adds.
> 
> 
> Diffs
> -----
> 
>   kresources/kabc/resourceakonadi.h f2075a4 
>   kresources/kabc/resourceakonadi.cpp d2ea349 
>   kresources/kcal/resourceakonadi.h a220616 
>   kresources/kcal/resourceakonadi.cpp d2c9415 
>   kresources/shared/sharedresourceprivate.h 8019204 
>   kresources/shared/subresourcemodel.h b6f4dc2 
> 
> Diff: http://git.reviewboard.kde.org/r/101229/diff
> 
> 
> Testing
> -------
> 
> Tested with having only the Facebook resource - resource selection dialog not shown.
> Tested with having Facebook and a local ical Akonadi resource - resource selection dialog shown.
> 
> 
> Thanks,
> 
> Thomas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/