[Kde-pim] Re: Review Request: kmail: "Local folders" are renamed to "Kmail Folders" after migration

[Thomas McGuire]

> On April 12, 2011, 5:44 p.m., Thomas McGuire wrote:
> > Looks good to me.
> > Kevin, what do you think?
> 
> Kevin Krammer wrote:
>     I am afraid I don't get the problem.
>

There are two problems in the bug report:
- Reporter is confused that the folder name is now "KMail Folders" instead of "Local Folders", like in KMail 1. I agree and think "Local Folders" is a better name.
- For the reporter, the top-level folder can't be renamed, probably because it is read-only or has the wrong ACLs. This is not covered by this review request, though.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101107/#review2594
-----------------------------------------------------------


On April 12, 2011, 5:11 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101107/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 5:11 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> After a migration the local folders are renamed to kmail folders. So with this patch the issue is solved. 
> 
> 
> This addresses bug 260572.
>     http://bugs.kde.org/show_bug.cgi?id=260572
> 
> 
> Diffs
> -----
> 
>   migration/kmail/kmailmigrator.cpp 7adeef8 
> 
> Diff: http://git.reviewboard.kde.org/r/101107/diff
> 
> 
> Testing
> -------
> 
> kdepim and kdepim-runtime compile without any issue. Also kmail works fine.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/