[Kde-pim] Re: Review Request: Fix non-ascii symbols in From and To symbols replaced to "?" when sending email

[Alexey Korepov]

> On April 16, 2011, 9:06 p.m., Thomas McGuire wrote:
> > A fixed the bug now, in a different way: When attempting to encode an RFC2047 string in KMime that can't be encoded with the selected charset, use UTF-8 as a fallback.
> > See http://commits.kde.org/kdepimlibs/7b75f8a769ef0e40e59dedb1327ff0ed51e63ba9
> > 
> > This should fix the problem without needing the hacks in composeFinalStep(), I assume the same hacks would be needed in other places as well.
> > 
> > BTW, the encoding charset gets lost in Content::parse(). Conceptually, that even makes sense, since a header can contain multiple different encodings, i.e. each word or comment might use a different charset, so parsing a header can't recover the "ultimate" charset.
> > 
> > Please test.
> 
> Cristian Oneț wrote:
>     I have tested your fix and it works (even the newer version https://projects.kde.org/projects/kde/kdepimlibs/repository/revisions/3b223154aebed90f92fc8588ee8a38a0f5063c14). Thanks!
>     
>     I would argue though to keep the messagecomposer/tests/composertest.cpp part of the path from this review because I think it makes the test for this bug complete.
> 
> Thomas McGuire wrote:
>     Right, I forgot about that, sorry.
>     Added back in http://commits.kde.org/kdepim/75822104681a7a7d326832a0c8968843e31d266f

I have tested kmail2 version from GIT from 2011-04-17 - all works good with russian letters, many thanks!


- Alexey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101109/#review2688
-----------------------------------------------------------


On April 17, 2011, 4:09 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101109/
> -----------------------------------------------------------
> 
> (Updated April 17, 2011, 4:09 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> As stated in the bug report this might not be the cleanest fix that bug can have but since no kdepim developer has yet stepped up to fix the bugI submitted this review request hoping to draw some attention to this issue.
> 
> The bug report also contains the description of the source of the bug so there is no point in duplicating it here.
> 
> 
> This addresses bug 263761.
>     http://bugs.kde.org/show_bug.cgi?id=263761
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer.cpp ec3cd2f 
>   messagecomposer/skeletonmessagejob.cpp 2e708f1 
>   messagecomposer/tests/composertest.cpp 6e71c4a 
> 
> Diff: http://git.reviewboard.kde.org/r/101109/diff
> 
> 
> Testing
> -------
> 
> Run kmail2 and add contacts with non-ascii characters in their name. Save as a draft or send the mail and observe that the non-ascii characters are successfully preserved.
> 
> 
> Thanks,
> 
> Cristian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/