[Kde-pim] Re: Review Request: Fix non-ascii symbols in From and To symbols replaced to "?" when sending email

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101109/
-----------------------------------------------------------

(Updated April 13, 2011, 11 p.m.)


Review request for KDEPIM.


Changes
-------

Updated the patch so that the test case will work. Although this does not fix the bug. The main difference between kmail's flow and the test case is that KMime::Content::assemble is called before the message is saved. Now if you do the same in the test case call assemble, save the encodedContent as a string and you try to create a new KMime:Message based on then content you'll encounter the same bug.
So the initial workaround is kept in order that the extra call to 'KMime::Content::assemble' will produce the correct output. This is still not the desired fix but I don't have a better one and this at least works.


Summary
-------

As stated in the bug report this might not be the cleanest fix that bug can have but since no kdepim developer has yet stepped up to fix the bugI submitted this review request hoping to draw some attention to this issue.

The bug report also contains the description of the source of the bug so there is no point in duplicating it here.


This addresses bug 263761.
    http://bugs.kde.org/show_bug.cgi?id=263761


Diffs (updated)
-----

  messagecomposer/composer.cpp ec3cd2f 
  messagecomposer/skeletonmessagejob.cpp 2e708f1 

Diff: http://git.reviewboard.kde.org/r/101109/diff


Testing
-------

Run kmail2 and add contacts with non-ascii characters in their name. Save as a draft or send the mail and observe that the non-ascii characters are successfully preserved.


Thanks,

Cristian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/