[Kde-pim] Re: Review Request: make autoSaveCopyResult conform

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101072/#review2566
-----------------------------------------------------------

Ship it!


Looks mostly good, but please put the body of the if-clause inside braces before you commit.

But I'm wondering whether something more should be done if migration of the autosaved messages failed. As it is now the migration of the autosaved messages will fail silently. Shouldn't the user be informed?

- Ingo


On April 9, 2011, 6 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101072/
> -----------------------------------------------------------
> 
> (Updated April 9, 2011, 6 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Regarding to kdelibs/kdecore/jobs/kjobs.h at line 52:
>    if ( job->error() )
>        doSomething();
> because of, at line 254:
>    @return the error code for this job, 0 if no error.
> is the method autoSaveCopyResult not conform. It produces an error:
> kmail-migrator(1691) KMail::KMailMigrator::autoSaveCopyResult: error= 0 text= "Unknown error code 0
> 
> I propose to add one line.
> 
> 
> Diffs
> -----
> 
>   migration/kmail/kmailmigrator.cpp 7adeef8 
> 
> Diff: http://git.reviewboard.kde.org/r/101072/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/