[Kde-pim] Re: Review Request: Fix non-ascii symbols in From and To symbols replaced to "?" when sending email

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101109/#review2603
-----------------------------------------------------------


Christian, thank you for looking into this and apologies for not answering on the bug report.
The patch seems to work around the problem, however I would prefer a fix in a more appropriate place. The To/From/CC headers are first set in SkeletonMessageJobPrivate::doStart() in messagecomposer/skeletonmessagejob.cpp, I assume this is the place in which the charset is not set correctly (or simply not set at all). That function also sets the subject, for which it works correctly.

In addition, could you add a unit test for this, to ensure that the problem stays fixed? Just add a quick test to tests/composertest.cpp for this.

- Thomas


On April 12, 2011, 8:34 p.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101109/
> -----------------------------------------------------------
> 
> (Updated April 12, 2011, 8:34 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> As stated in the bug report this might not be the cleanest fix that bug can have but since no kdepim developer has yet stepped up to fix the bugI submitted this review request hoping to draw some attention to this issue.
> 
> The bug report also contains the description of the source of the bug so there is no point in duplicating it here.
> 
> 
> This addresses bug 263761.
>     http://bugs.kde.org/show_bug.cgi?id=263761
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composer.cpp ec3cd2f 
> 
> Diff: http://git.reviewboard.kde.org/r/101109/diff
> 
> 
> Testing
> -------
> 
> Run kmail2 and add contacts with non-ascii characters in their name. Save as a draft or send the mail and observe that the non-ascii characters are successfully preserved.
> 
> 
> Thanks,
> 
> Cristian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/