[Kde-pim] Re: Review Request: Emit changed signals for subentities of an explicitly monitored collection

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101169/#review2852
-----------------------------------------------------------


I think the patches I put here are better: 

http://thread.gmane.org/gmane.comp.kde.devel.pim/30285/focus=30320

It will need unit tests though, and I won't get a chance to write them before Monday at the earliest.

- Stephen


On April 23, 2011, 1:31 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101169/
> -----------------------------------------------------------
> 
> (Updated April 23, 2011, 1:31 p.m.)
> 
> 
> Review request for KDEPIM and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> This is based on a patch I got from skelly, with minor modifications. 
> 
> The patch ensures that all needed collections are prefetched, so we can check for subentities of a collection.
> 
> Please note that the ETM as it is in master will not work, so some further patches for ETM are needed to test it.
> 
> 
> Diffs
> -----
> 
>   akonadi/monitor.h 03a5af1a47a30a513babf5a4466575932c43ac4a 
>   akonadi/monitor.cpp 54cbc399676d0e36c2ca06d9061420cf7f31ade7 
>   akonadi/monitor_p.h 59df09097d447695e00a88a1d99b28c3521aa8b1 
>   akonadi/monitor_p.cpp b846edb1d1d8a915b4ed274326752ca44665e289 
> 
> Diff: http://git.reviewboard.kde.org/r/101169/diff
> 
> 
> Testing
> -------
> 
> Seems to work....
> 
> 
> Thanks,
> 
> Christian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/