[Kde-pim] Re: Review Request: ktimetracker - editing desktop list on a not-new task doesn't work

[Thorsten Staerk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100952/#review2515
-----------------------------------------------------------

Ship it!


regarding revision 2 of your patch:
- desktopcheckboxes[i]->isEnabled() will be true if any of the checkboxes is tagged. 
- desktopList->clear() is a waste of time as all elements of this vector will be set or unset anyway
- I do not like a return in the middle of a function because of programming flow considerations

All in all I really appreciate your code, go on!

Please understand that desktopcheckboxes[i]->isEnabled() should just be thought of as "is any checkbox tagged".

I will submit your patch now, just not the lines that contradict my three points at the top of this text.

- Thorsten


On April 3, 2011, 8:42 a.m., Cristi Posoiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100952/
> -----------------------------------------------------------
> 
> (Updated April 3, 2011, 8:42 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> it seems you can't *change* the desktops you're tracking the task on.
> Problem being the list of currently checked desktops is not retreived so that the task is updated.
> 
> 
> Diffs
> -----
> 
>   ktimetracker/edittaskdialog.cpp 103c95c 
>   ktimetracker/taskview.cpp 55bc975 
> 
> Diff: http://git.reviewboard.kde.org/r/100952/diff
> 
> 
> Testing
> -------
> 
> - create task; add it 
> - edit the task again
> - change desktops settings (set auto-tracking = true)
> - press ok
> - edit again the task
> -- you'll see your changes re: desktops are not there
> 
> 
> Thanks,
> 
> Cristi
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/