[Kde-pim] Re: Review Request: Kmail: check fcc collection in the MDA.

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100829/#review2363
-----------------------------------------------------------



agents/maildispatcher/sendjob.cpp
<http://git.reviewboard.kde.org/r/100829/#comment2033>

    moveTo is unused now.
    In fact the whole structure of the code now doesn't make sense anymore. For example, when the sentBehaviour attribute has a behaviour of MoveToDefaultCollection, the mail is not moved at all anymore!
    
    To correct this, you should probably still start an ItemMoveJob in line 279, with the default collection. Also, in line 277, the job should be aborted with an error. Both of these things were done in the code a bit below that was removed.
    After that, the moveTo variable can be removed.


- Thomas


On March 23, 2011, 12:22 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100829/
> -----------------------------------------------------------
> 
> (Updated March 23, 2011, 12:22 p.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> This patch is fixing a hole in the MDA. If the fcc folder is deleted when the message is queued, then the mail is lost. With my patch the mail is saving in the default sent-mail collection. I forgot to check for the whitespace... So i update my diff. Sorry for the trouble.
> 
> 
> Diffs
> -----
> 
>   agents/maildispatcher/sendjob.h 8f0cdc8 
>   agents/maildispatcher/sendjob.cpp 8e1fcc1 
> 
> Diff: http://git.reviewboard.kde.org/r/100829/diff
> 
> 
> Testing
> -------
> 
> Kdepim-runtime and kdepim is compiling without any issue.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/