[Kde-pim] Re: Review Request: Fix non-ascii symbols in From and To symbols replaced to "?" when sending email

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101109/
-----------------------------------------------------------

(Updated April 13, 2011, 11:24 p.m.)


Review request for KDEPIM.


Changes
-------

Updated the test case so that it matches the scenario in kmail. Once the result from the composer is obtained try to assemble the message (serialize it) and then parse the resulting representation. Without the patch it fails. I think that this addition makes the test case complete for the reported bug.

The initial version of the test case will succeed only with the changes in messagecomposer/skeletonmessagejob.cpp but only those fixes are not enough for the reported bug.

With this being said I restate a previous question of mine:
"I don't get it why, when parsing a RFC2047 serialized element which had the charset UTF-8, the charset of the resulting KMime object is not set to UTF-8. I think that this is the real root of the problem." - The current fix manually sets the charset of the resulting KMime objectto UTF-8.


Summary
-------

As stated in the bug report this might not be the cleanest fix that bug can have but since no kdepim developer has yet stepped up to fix the bugI submitted this review request hoping to draw some attention to this issue.

The bug report also contains the description of the source of the bug so there is no point in duplicating it here.


This addresses bug 263761.
    http://bugs.kde.org/show_bug.cgi?id=263761


Diffs (updated)
-----

  messagecomposer/composer.cpp ec3cd2f 
  messagecomposer/skeletonmessagejob.cpp 2e708f1 
  messagecomposer/tests/composertest.cpp 6e71c4a 

Diff: http://git.reviewboard.kde.org/r/101109/diff


Testing
-------

Run kmail2 and add contacts with non-ascii characters in their name. Save as a draft or send the mail and observe that the non-ascii characters are successfully preserved.


Thanks,

Cristian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/