[Kde-pim] Re: Review Request: Reset the ETM when an explicitly monitored collection is moved

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101192/#review2845
-----------------------------------------------------------

Ship it!


Yes, this is ok.

I think you need a similar reset in the remove case for the same reason, right?

I don't think the alternative you note would be impossible either though a few opportunities for reuse between the methods would come up. Maybe I'll do that at some stage.

- Stephen


On April 23, 2011, 11:29 a.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101192/
> -----------------------------------------------------------
> 
> (Updated April 23, 2011, 11:29 a.m.)
> 
> 
> Review request for KDEPIM and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> Since parent collections of the monitored collection might have been included to be able to display the monitored collection, we have to reevaluate the tree. And since it is probably not that often that a monitored collection (usually the root of the tree), is moved, we can just reset.
> 
> 
> I'll remove the debug statement before committing.
> 
> 
> Diffs
> -----
> 
>   akonadi/entitytreemodel_p.cpp 2499a30 
> 
> Diff: http://git.reviewboard.kde.org/r/101192/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/