[Kde-pim] Re: Review Request: KIMAP::LoginJob: add a method to get the last response from the server

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101034/#review2442
-----------------------------------------------------------


What would be the use case apart from logging?

Also I'm wondering if for the error case we shouldn't use the KJob facilities already in place, in which case this response would be stored only for the successful login case, and then the method could be renamed to "serverGreeting()" or something like that.

- Kevin


On April 6, 2011, 2:51 a.m., Gregory Schlomoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101034/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 2:51 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> Small patch to add the ability to get the last response sent by the server after login.
> 
> This response isn't defined by the IMAP standard, but it may contain interesting information like ip address and date of last connection, etc...
> 
> This can be useful for logging purposes.
> 
> 
> Diffs
> -----
> 
>   kimap/loginjob.h 157f5bc 
>   kimap/loginjob.cpp 0f13ef4 
> 
> Diff: http://git.reviewboard.kde.org/r/101034/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/