[Kde-pim] Review Request: Fixes for ResourceScheduler task prepending and task defering

Kevin Krammer kevin.krammer at gmx.at
Wed Sep 15 12:06:39 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5357/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Two fixes:

1) Issue: ResourceBase::scheduleCustomTask with SchedulePriority::Prepend did prepend on the generic queue, so if there was a task in e.g. ChangeReplayQueue that one was executed first (executeNext() iterates through the queue array, taking the first non-empty one).
Fix: add a new queue as the first element of the array and prepend to that.

2) Issue: ResourceBase::deferTask() did append the current task to generic queue. If this was a recorded change this potentially reordered them.
Fix: prepend current task to the queue it came from


Diffs
-----

  /trunk/KDE/kdepimlibs/akonadi/resourcebase.h 1175580 
  /trunk/KDE/kdepimlibs/akonadi/resourcescheduler.cpp 1175580 
  /trunk/KDE/kdepimlibs/akonadi/resourcescheduler_p.h 1175580 

Diff: http://svn.reviewboard.kde.org/r/5357/diff


Testing
-------


Thanks,

Kevin

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list