[Kde-pim] KMail Help actions

[Burkhard Lück]

Am Montag, 16. August 2010, um 22:46:14 schrieb Ingo Klöcker:
> On Sunday 15 August 2010, Burkhard Lück wrote:
> > Hi kdepim devels,
> > 
> > I found some issues with the Help action in KMail:
> > 
> > 1) kmail_view.desktop has an entry X-DocPath=kmail/index.html so this
> > item appears as "KMail view" in the navigation tree of khelpcenter.
> > Is this really intended, does that desktop file need a X-DocPath?
> > Removing the X-DocPath entry here would also remove the item from
> > khelpcenters navigation tree, but maybe this is used elsewhere like
> > e.g. in Kontact?
> 
> No. It's just used for being able to view saved messages with KMail. I
> guess that kmail_view.desktop was simply copied from kmail.desktop.
> Yeah, indeed, this DocPath entry has been in this desktop files since it
> has first been committed to svn. Please remove it.
> 
> > 2) aboutdata.cpp has: KAboutData( "kmail2", "kmail",
> > ki18n("KMail"),KMAIL_VERSION,
> > 
> > Launching the Handbook from menu Help->KMail Handbook therefore tries
> > to load kmail2/index.html, but the documentation is installed in
> > kmail/index.html.
> > 
> > Launching the Handbook from the Help buttons in the settings pages
> > loads kmail/index.html#configure-*, that works properly due to the
> > entries like
> > kmail_config_*.desktop:14:X-DocPath=kmail/index.html#configure-*
> > 
> > How to solve this?
> > Rename the doc to kmail2 and change all X-DocPath entries
> > accordingly?
> 
> Yeah. Makes sense. This would also allow people to have kmail and kmail2
> installed in parallel.
> 
I found another solution to fix the wrong documentation help call. 
Renaming KMail.desktop to KMail2.desktop enables KToolInvocation::invokeHelp() 
to read the X-DocPath from the desktop file.
So instead of changing the X-DocPath in six kmail_config_*.desktop files and 
renaming the kmail documentation and all translations a simple
$mv KMail.desktop KMail2.desktop
is sufficient to make the help call work again.

Are there any objections to rename KMail.desktop to KMail2.desktop?

-- 
Burkhard Lück
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/