[Kde-pim] Review Request: Using KTimeEdit and KDateEdit in korganizer-mobile

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5434/#review7758
-----------------------------------------------------------

Ship it!


fine and dandy

- Allen


On 2010-09-24 02:52:46, Anselmo Melo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5434/
> -----------------------------------------------------------
> 
> (Updated 2010-09-24 02:52:46)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is the second of two review requests about changing widgets in incidenceeditor-ng for korganizer-mobile.
> 
> The diff replaces QTimeEdit with KTimeEdit and QDateEdit with KDateEdit in eventortodomobile.ui, updates the qobject_casts done in incidenceview.cpp and changes the remaining signals to use {time,date}Edited() instead of {time,date}Changed().
> 
> At this point, the incidence editor shows the new QML widgets for time/date selection, but there are bugs to fix / integration to conclude.
> 
> The actions which are going to use the new timeChanged() signal are not in this patch. They are related with things like the automatic update of the end{time,date} fields when the start field is set.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/incidenceeditor-ng/eventortodomobile.ui 1177695 
>   /trunk/KDE/kdepim/incidenceeditor-ng/incidencedatetime.h 1177534 
>   /trunk/KDE/kdepim/incidenceeditor-ng/incidencedatetime.cpp 1177534 
>   /trunk/KDE/kdepim/mobile/lib/calendar/incidenceview.h 1178286 
>   /trunk/KDE/kdepim/mobile/lib/calendar/incidenceview.cpp 1178286 
> 
> Diff: http://svn.reviewboard.kde.org/r/5434/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anselmo
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/