[Kde-pim] Review Request: Add zoom in/out buttons to KMail reader.

Martin Hignett reviewboard.kde.org at hignett.clara.co.uk
Mon Sep 20 19:08:39 BST 2010



> On 2010-09-20 17:50:05, Torgny Nyblom wrote:
> > Any progress on this, or any prospect of getting it done?
> > If not please mark it as discarded.

Sorry, I've been swamped with 'real life' stuff. From what I can tell the email viewing code has been completely replaced so I will most likely have to start again. Has anyone checked if this is still an issue with the new code? In any case, I think the best thing to do is mark this as abandoned and if I find the time I'll create a new patch against the current code.


Thanks


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/2456/#review7694
-----------------------------------------------------------


On 2009-12-28 21:37:36, Martin Hignett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/2456/
> -----------------------------------------------------------
> 
> (Updated 2009-12-28 21:37:36)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Provides a zoom in/out button, context menu and shortcuts (the + and - keys on the numeric keypad) for the KMail reader.
> I'm not sure how to add the toolbar buttons to the default toolbar, but when they are added, this works.
> 
> 
> This addresses bug 59576.
>     https://bugs.kde.org/show_bug.cgi?id=59576
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1067045 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1067045 
>   /trunk/KDE/kdepim/kmail/kmreadermainwin.h 1067045 
>   /trunk/KDE/kdepim/kmail/kmreadermainwin.cpp 1067045 
> 
> Diff: http://svn.reviewboard.kde.org/r/2456/diff
> 
> 
> Testing
> -------
> 
> Tested that + and - keys, context menu and toolbar buttons work.
> Tested that the zoom has sensible minimum and maximum bounds beyond which it won't go (these match the bounds defined in KHTMLPart).
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list