[Kde-pim] Review Request: refactor kmail's recipient editor into a generic widget

[Bertjan Broeksema]

As far as I know, this is indeed committed and can be closed.

Cheers,

Bertjan

On Monday 20 September 2010 19:47:40 Torgny Nyblom wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4438/#review7693
> -----------------------------------------------------------
> 
> 
> Has this been committed? If so please close it.
> 
> - Torgny
> 
> On 2010-06-21 21:31:35, casey wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://svn.reviewboard.kde.org/r/4438/
> > -----------------------------------------------------------
> > 
> > (Updated 2010-06-21 21:31:35)
> > 
> > 
> > Review request for KDE PIM, Bertjan Broeksema and Thomas McGuire.
> > 
> > 
> > Summary
> > -------
> > 
> > This commit refactors the recipients editor in kmail into a generic
> > widget (libkdepim/MultiplyingLineEditor). This new widget can now be
> > used in other similar situations (such as the event attendee editor,
> > which is coming soon TM ).
> > 
> > I implemented this new editor alongside the original recipients editor,
> > so some renaming of classes might yet be appropriate.
> > 
> > 
> > Diffs
> > -----
> > 
> >   /branches/work/komo/kdepim/kmail/kmcomposewin.h 1139614
> >   /branches/work/komo/kdepim/kmail/kmcomposewin.cpp 1139614
> >   /branches/work/komo/kdepim/libkdepim/CMakeLists.txt 1139614
> >   /branches/work/komo/kdepim/libkdepim/multiplyingline.h PRE-CREATION
> >   /branches/work/komo/kdepim/libkdepim/multiplyingline.cpp PRE-CREATION
> >   /branches/work/komo/kdepim/libkdepim/multiplyinglineeditor.h
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/libkdepim/multiplyinglineeditor.cpp
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/libkdepim/multiplyinglineeditor_p.h
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/libkdepim/multiplyinglineeditor_p.cpp
> >   PRE-CREATION /branches/work/komo/kdepim/messagecomposer/CMakeLists.txt
> >   1139614 /branches/work/komo/kdepim/messagecomposer/composerviewbase.h
> >   1139614
> >   /branches/work/komo/kdepim/messagecomposer/composerviewbase.cpp
> >   1139614
> >   /branches/work/komo/kdepim/messagecomposer/distributionlistdialog.h
> >   1139614
> >   /branches/work/komo/kdepim/messagecomposer/distributionlistdialog.cpp
> >   1139614 /branches/work/komo/kdepim/messagecomposer/recipient-ng.h
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/messagecomposer/recipient-ng.cpp
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/messagecomposer/recipientline-ng.h
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/messagecomposer/recipientline-ng.cpp
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/messagecomposer/recipientseditor-ng.h
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/messagecomposer/recipientseditor-ng.cpp
> >   PRE-CREATION
> >   /branches/work/komo/kdepim/messagecomposer/recipientseditorsidewidget.
> >   h PRE-CREATION
> >   /branches/work/komo/kdepim/messagecomposer/recipientseditorsidewidget.
> >   cpp PRE-CREATION
> >   /branches/work/komo/kdepim/messagecomposer/recipientspicker.h 1139614
> > 
> > Diff: http://svn.reviewboard.kde.org/r/4438/diff
> > 
> > 
> > Testing
> > -------
> > 
> > Opened up kmail outfitted with the new recipient editor and another kmail
> > with the older version side by side, and tested inputs to verify they
> > exhibited same behavior.
> > 
> > 
> > Thanks,
> > 
> > casey
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/