[Kde-pim] Re: Review Request: KCalCore: Add a way to know which incidence fields changed

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5673/#review8280
-----------------------------------------------------------

Ship it!


looks fine

- Allen


On 2010-10-20 18:15:04, Sergio Martins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5673/
> -----------------------------------------------------------
> 
> (Updated 2010-10-20 18:15:04)
> 
> 
> Review request for KDE PIM, Allen Winter and Alvaro Manera.
> 
> 
> Summary
> -------
> 
> KOrganizer has an enums like:
> 
>     enum WhatChanged {
>       PRIORITY_MODIFIED,
>       COMPLETION_MODIFIED,
>       CATEGORY_MODIFIED,
>       DATE_MODIFIED,
>       RELATION_MODIFIED,
>       ALARM_MODIFIED,
>       DESCRIPTION_MODIFIED,
>       SUMMARY_MODIFIED,
>       COMPLETION_MODIFIED_WITH_RECURRENCE,
>       RECURRENCE_MODIFIED_ONE_ONLY,
>       RECURRENCE_MODIFIED_ALL_FUTURE,
>       UNKNOWN_MODIFIED,
>       NOTHING_MODIFIED
>     };
> 
> and tries to keep track of which incidence properties changed.
> 
> The main purpose of this is to be able to craft i18n strings when sending invitations, depending on what fields changed.
> 
> Currently this is a bit messy/hacky and forces KCalCore users to keep track of changes, and they can easily forget to do it.
> 
> My patch moves this logic into KCalCore.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcalcore/event.cpp 1187909 
>   trunk/KDE/kdepimlibs/kcalcore/incidence.cpp 1187909 
>   trunk/KDE/kdepimlibs/kcalcore/incidencebase.h 1187909 
>   trunk/KDE/kdepimlibs/kcalcore/incidencebase.cpp 1187909 
>   trunk/KDE/kdepimlibs/kcalcore/todo.cpp 1187909 
> 
> Diff: http://svn.reviewboard.kde.org/r/5673/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/