[Kde-pim] Re: Review Request: Make it possible to search incidences by uid: IncidenceSearchJob

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5515/
-----------------------------------------------------------

(Updated 2010-10-03 22:33:09.630369)


Review request for KDE PIM, Volker Krause and Tobias Koenig.


Changes
-------

Only return items that are subclasses of ncal:UnionOfEventJournalTodo.


Summary
-------

This patch is against 4.5 because I had nepomuk working there and not in trunk, but will only commit in trunk.

Based on ContactSearchJob.


Diffs (updated)
-----

  branches/KDE/4.5/kdepimlibs/akonadi/kcal/CMakeLists.txt 1181725 
  branches/KDE/4.5/kdepimlibs/akonadi/kcal/incidencesearchjob.h PRE-CREATION 
  branches/KDE/4.5/kdepimlibs/akonadi/kcal/incidencesearchjob.cpp PRE-CREATION 
  branches/KDE/4.5/kdepimlibs/akonadi/kcal/tests/CMakeLists.txt PRE-CREATION 
  branches/KDE/4.5/kdepimlibs/akonadi/kcal/tests/incidencesearcher.h PRE-CREATION 
  branches/KDE/4.5/kdepimlibs/akonadi/kcal/tests/incidencesearcher.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5515/diff


Testing
-------

$ ./incidencesearcher KOrg
Found  0  incidences using  "ExactMatch" 
Found  2  incidences using  "StartsWithMatch" 
Found  2  incidences using  "ContainsMatch" 
Found  3  incidences using  "No query" 

$ ./incidencesearcher KOrganizer-1589469735.123
Found  1  incidences using  "ExactMatch" 
Found  1  incidences using  "StartsWithMatch" 
Found  1  incidences using  "ContainsMatch" 
Found  3  incidences using  "No query" 

$ ./incidencesearcher 123
Found  0  incidences using  "ExactMatch" 
Found  0  incidences using  "StartsWithMatch" 
Found  1  incidences using  "ContainsMatch" 
Found  3  incidences using  "No query" 


Thanks,

Sergio

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/