[Kde-pim] Re: Review Request: Make selection drawing in EventVIews optional

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5542/#review8012
-----------------------------------------------------------


The "date range" concept refers to only displaying incidences between two dates, for example, baseview.h: virtual bool supportsDateRangeSelection(); returns false for to-do view, and true for agenda/month view.

So I think we should use another name in your patch, or just change the baseview.h one to something else, supportsDateRangeFiltering()?.

- Sergio


On 2010-10-07 11:23:56, Bertjan Broeksema wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5542/
> -----------------------------------------------------------
> 
> (Updated 2010-10-07 11:23:56)
> 
> 
> Review request for KDE PIM and Sergio Martins.
> 
> 
> Summary
> -------
> 
> Date range selection doesn't make sense in the mobile applications (at least not in its current incarnation). Therefore add a method to disable painting of selection. Currently only for AgendaView.
> 
> 
> This addresses bug 252245.
>     https://bugs.kde.org/show_bug.cgi?id=252245
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/calendarviews/eventviews/agenda/agenda.cpp 1183391 
>   /trunk/KDE/kdepim/calendarviews/eventviews/eventview.h 1183391 
>   /trunk/KDE/kdepim/calendarviews/eventviews/eventview.cpp 1183391 
>   /trunk/KDE/kdepim/calendarviews/eventviews/eventview_p.h 1183391 
>   /trunk/KDE/kdepim/calendarviews/eventviews/eventview_p.cpp 1183391 
> 
> Diff: http://svn.reviewboard.kde.org/r/5542/diff
> 
> 
> Testing
> -------
> 
> Tested it in both mobile (with selection drawing disabled) and korganizer (with selection drawing enabled). Both work as expected.
> 
> 
> Thanks,
> 
> Bertjan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/