[Kde-pim] Re: Review Request: [akonadi] Link akonadi_agent_launcher agains AKONADI_SYSTEM_LIBS

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5607/#review8089
-----------------------------------------------------------

Ship it!


looks ok to me

- Volker


On 2010-10-12 01:37:39, Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5607/
> -----------------------------------------------------------
> 
> (Updated 2010-10-12 01:37:39)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This patch fixes compilation on FreeBSD when libexecinfo (which provides `backtrace' and `backtrace_symbols') is installed. Since they're not in libc on FreeBSD, libexecinfo is explicitly added to AKONADI_SYSTEM_LIBS in the top-level CMakeLists.txt. However, since akonadi_agent_launcher does not link against AKONADI_SYSTEM_LIBS (but uses the files in shared/*), linking fails.
> 
> 
> Diffs
> -----
> 
>   trunk/kdesupport/akonadi/agentserver/CMakeLists.txt 1184972 
> 
> Diff: http://svn.reviewboard.kde.org/r/5607/diff
> 
> 
> Testing
> -------
> 
> After the patch was applied, akonadi compiled successfully.
> 
> 
> Thanks,
> 
> Raphael
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/